add createUser method on ApiClient #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@psrpinto & I discussed it would probably be best if user is prompted with author info to be filled out, after we have identified how many authors are there and already processed them. This could be a fitting thing for a "finalise import" step where we would potentially need to run a bunch of things after liberating data to make it fitting for a WP install - such as liberating media assets. |
psrpinto
reviewed
Sep 25, 2024
psrpinto
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a method to create the user, which would be authors in our use case. Currently not called from anywhere.
username,emailandpasswordare 3 required fields, but only details I can imagine we would have to work with, would bename+ possibly ausernameat times.usernameis also not modifiable. A DB query is possible of course but it escapes me why it's recommended to not change/editusername.Regardless this isn't a problem, since we can create temp users with whatever data we have. Afterwards the administrator can create new users with the right details and then just delete the ones created by us. At delete, WordPress prompts with the option of re-assigning all content attributed to the user being deleted to another user. So, it works out.